-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix refactor #506
Nix refactor #506
Conversation
This reverts commit af1cd2b.
@KoviRobi I would love your opinion about this proposal. After diving into Nix ecosystem, I changed my mind about our last discussion. I believe that the source of truth should resides in Nixpkgs because it's the common base for any derivation. This repo should just override it (see EDIT: I may merge the PR before your opinion, it does not mean I do not care about it (we can always adjust afterwards), I just need to validate the common Nix repo for Pimalaya and go forward. |
0a9a85b
to
cb07713
Compare
f47ba78
to
0ae35be
Compare
Sorry, I wanted to get back to you, but didn't have the time/energy.
Very reasonable, sorry sometimes life gets in the way, plus this is hobby/interest for me to get a decent mail setup so often slow to reply. I think it looks good, I see you've managed to remove duplication! I'm not a nix expert btw, just saw some issues I could help with so did :) And I do really like the whole pimalaya project you have going on, I was looking to have a better e-mail setup than outlook web app, especially as at work we use gerrit which sends a lot of emails so I'd need some more complex filtering than outlook can do (maybe something with notmuch and taskwarrior?). But wanted to say that realistically I will only be sporadically committing/contributing, and I think you've got a good approach, I'm also of the view that things can be fixed later too, don't want pull requests to drag on forever. Sorry I'm rambling a bit, I'm just not sure I/we as a community have found the best way to do open source software, and ever since the XZ utils, it's been on the back of my mind, and keep just hoping to find ways in which my contributions will be a net positive rather than negative, and ways to help avoid burnout of maintainers for software I use. |
No need to be sorry, we all do what we can with what we have. I am really thankful to your initiative, the Nix topic was sth I was postponing for too long, and you initiated the changes.
If you stay tuned, you may see a task & time manager joining the Pimalaya family next year! And should integrate well with other projects. It will be a refactor of the existing Unfog project of mine, using Rust and Pimalaya libs. You should also see contact and calendar tools. |
There is too much duplicated Nix code among Pimalaya projects and Nixpkgs.
This PR brings the first milestones:
default.nix
andshell.nix
. This way dependencies and cargo features can be easily overriden by--arg
and--argstr
. Nix flake can still be used like before.naersk
orcrane
. This way the source of truth resides in and only in nixpkgs.package.nix
contains the final package that will be released inside nixpkgs, it should disappear as soon as possible.Aside from Nix, this PR also:
1.82
.Related to #504 #505 pimalaya/core#22.
Fixes #500.