-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove php version from composer #276
Conversation
# Conflicts: # .github/workflows/open-search-codeception.yaml
Why do you remove it? |
I was instructed to do so because as pimcore/pimcore is required in every bundle it should be maintained there. Best Alex |
@alexz707 I don't think that's a good idea. What if php version 8.5 is added to pimcore/pimcore, but this bundle is not ready for 8.5 yet? Then 8.3/8.4 cannot simply be added here, because then composer will load the latest version without php restriction. Each package should define its own dependencies and not refer to dependencies of a dependency, these can change. |
did not see your reply before. For now I'll re-add it |
Quality Gate passedIssues Measures |
Changes in this pull request
Resolves #
Additional info