Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove php version from composer #276

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Remove php version from composer #276

merged 8 commits into from
Jan 15, 2025

Conversation

alexz707
Copy link

Changes in this pull request

Resolves #

Additional info

@alexz707 alexz707 changed the base branch from 1.x to 2.x January 15, 2025 10:03
@jdreesen
Copy link
Contributor

Why do you remove it?

@alexz707
Copy link
Author

Why do you remove it?

I was instructed to do so because as pimcore/pimcore is required in every bundle it should be maintained there.
Only excpetion would be if a bundle needs to narrow down the version e.g. works only with 8.4 then we should keep it in the bundle itself.

Best Alex

@blankse
Copy link

blankse commented Jan 15, 2025

@alexz707 I don't think that's a good idea. What if php version 8.5 is added to pimcore/pimcore, but this bundle is not ready for 8.5 yet? Then 8.3/8.4 cannot simply be added here, because then composer will load the latest version without php restriction.

Each package should define its own dependencies and not refer to dependencies of a dependency, these can change.

@alexz707
Copy link
Author

alexz707 commented Jan 15, 2025

@alexz707 I don't think that's a good idea. What if php version 8.5 is added to pimcore/pimcore, but this bundle is not ready for 8.5 yet? Then 8.3/8.4 cannot simply be added here, because then composer will load the latest version without php restriction.

Each package should define its own dependencies and not refer to dependencies of a dependency, these can change.

did not see your reply before.
Yes I completely agree with you and it needs to be discussed again.
Will take that with me to our steering board meeting tomorrow.

For now I'll re-add it
Best Alex

@alexz707 alexz707 merged commit b5520af into 2.x Jan 15, 2025
10 checks passed
@alexz707 alexz707 deleted the update-php branch January 15, 2025 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2025
@alexz707 alexz707 added this to the 2.0.0 milestone Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants