Implement undo #520
Implement undo #520
Conversation
|
I don't fully understand why one tests is failing: https://builds.sr.ht/~whynothugo/job/981248#task-test-262 |
Recurring test doesn't work because there are some recursion fields that are not persisted yet. We have to deal with some issues #485 in order for it to work. I'm planning on taking all of them but one step at a time. I tried to implement persistence for RELATED-TO but it was a pretty big change and it has its own issue #288. |
|
I have marked "not implemented" the test as the RELATED-TO property needs to be persisted before it can work. Now arch build passes (Alpine build just exploded and I don't understand why). |
|
Is there any progress?.. |
It should be ready to merge. I don't know if @WhyNotHugo has any more things to check. |
| Returns the todo that should be deleted. | ||
| """ | ||
| recurred = None | ||
| if self.is_recurring and self.related: |
There was a problem hiding this comment.
I ran:
todo new -l test test
todo new 1The completed todo looks like this:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:io.barrera.todoman
BEGIN:VTODO
COMPLETED:20231118T090119Z
CREATED:20231118T090107Z
DTSTAMP:20231118T090107Z
DUE:20231119T090107Z
LAST-MODIFIED:20231118T090119Z
PERCENT-COMPLETE:100
SEQUENCE:2
STATUS:COMPLETED
SUMMARY:test
UID:[email protected]
END:VTODO
END:VCALENDARIt doesn't have a recurrence rule any more (that is moved to the next one in the series), so this condition does not match.
If I run todo undo 1, both todos are kept around.
This is not ideal, but I don't think that it is terrible either. The RFC doesn't even cover how a recurring TODO is completed, so there's no correct behavior to any of this either way.
However, this if will never run, so this code is misleading. I think it should be removed (unless I'm missing something here).
The undo functionality does not really resolve recurring todos because that functionality is not implemented yet so there is a test that will fail until that is implemented (I'm planing to solve that myself, but one thing at a time).
@WhyNotHugo tell me if you see something off and sorry for taking that long, recurring todos distracted me a bit 😆