Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #88

Merged
merged 2 commits into from
Nov 17, 2023
Merged

Update dependencies #88

merged 2 commits into from
Nov 17, 2023

Conversation

nshalman
Copy link
Contributor

@nshalman nshalman commented Oct 5, 2023

Supercedes #82

Update min golang to 1.17 to match x/net
@nshalman nshalman marked this pull request as draft October 5, 2023 15:14
@pin pin marked this pull request as ready for review October 29, 2023 02:10
@pin
Copy link
Owner

pin commented Nov 17, 2023

Before this change the library is compatible with golang >= 1.13. After this change the library will be compatible with golang >= 1.17.

I was also considering bumping minimal golang version to 1.18 - makes dependencies much more tidy, probably golang.org/x/net dependencies are fully satisfied by 1.18 standard library?

But for now 1.17 gives better backward compatibility still, so let's go with that!

@nshalman, thank you for this change!

@pin pin merged commit e69c06d into pin:master Nov 17, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants