Cope with clients using the broadcast address #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some clients use the broadcast address (255.255.255.255) to reach the TFTP server in their network. This currently doesn't work because the server then use this address as the source address in its responses. But the broadcast address is not a valid source address and the sendmsg call fail with an `invalid argument` error. To cope with this check if the source address is the broadcast address and if so replace it with 0.0.0.0 to use the OS default. Signed-off-by: Alban Bedel <[email protected]>
|
LGTM! Apology for slow review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some clients use the broadcast address (255.255.255.255) to reach the TFTP server in their network. This currently doesn't work because the server then use this address as the source address in its responses. But the broadcast address is not a valid source address and the sendmsg call fail with an
invalid argumenterror.To cope with this check if the source address is the broadcast address and if so replace it with 0.0.0.0 to use the OS default.