Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates some docs as per DQTI #18948

Merged
merged 9 commits into from
Jan 23, 2025
Merged

updates some docs as per DQTI #18948

merged 9 commits into from
Jan 23, 2025

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Oct 31, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.5 (TiDB 8.5 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. labels Oct 31, 2024
@hfxsd hfxsd added needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. and removed contribution This PR is from a community contributor. labels Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 30, 2024
hfxsd
hfxsd commented Dec 31, 2024
View reviewed changes
tidb-storage.md Outdated Show resolved Hide resolved
hfxsd
hfxsd commented Dec 31, 2024
View reviewed changes
tiup/tiup-overview.md Outdated Show resolved Hide resolved
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed translation/doing This PR’s assignee is translating this PR. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 31, 2024
@hfxsd hfxsd requested a review from lilin90 December 31, 2024 08:54
@hfxsd hfxsd added translation/no-need No need to translate this PR. and removed translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Dec 31, 2024
@hfxsd hfxsd removed the needs-cherry-pick-release-8.4 Should cherry pick this PR to release-8.4 branch. label Jan 23, 2025
lilin90
lilin90 reviewed Jan 23, 2025
View reviewed changes
tidb-storage.md Outdated Show resolved Hide resolved
tidb-storage.md Outdated Show resolved Hide resolved
tidb-storage.md Outdated Show resolved Hide resolved
tidb-storage.md Outdated Show resolved Hide resolved
tidb-storage.md Outdated Show resolved Hide resolved
tiup/tiup-overview.md Outdated Show resolved Hide resolved
tiup/tiup-overview.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added translation/doing This PR’s assignee is translating this PR. and removed translation/no-need No need to translate this PR. labels Jan 23, 2025
lilin90
lilin90 reviewed Jan 23, 2025
View reviewed changes
tidb-storage.md Outdated Show resolved Hide resolved
lilin90
lilin90 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2025
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 03:14:10.217331439 +0000 UTC m=+323377.548250843: ☑️ agreed by lilin90.

@hfxsd hfxsd added lgtm do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 23, 2025
hfxsd
hfxsd commented Jan 23, 2025
View reviewed changes
tidb-storage.md Outdated Show resolved Hide resolved
@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 23, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jan 23, 2025

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 366a906 into pingcap:master Jan 23, 2025
7 checks passed
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 23, 2025
Merged
16 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19677.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 23, 2025
@ti-chi-bot
updates some docs as per DQTI (#18948) (#19677)
ff4f7d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@hfxsd hfxsd

Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/doing This PR’s assignee is translating this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hfxsd @ti-chi-bot @lilin90