Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install the ebs-csi-driver addon when creating aws eks cluster #2484

Merged
merged 3 commits into from
Jan 22, 2024
Merged

install the ebs-csi-driver addon when creating aws eks cluster #2484

merged 3 commits into from
Jan 22, 2024

Conversation

xjiaqing
Copy link
Contributor

@xjiaqing xjiaqing commented Jan 14, 2024 •
edited
Loading

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Update example eksctl file to install the ebs-csi-driver addon when creating aws eks cluster

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

@CLAassistant
Copy link

CLAassistant commented Jan 14, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 14, 2024

Welcome @xjiaqing!

It looks like this is your first PR to pingcap/docs-tidb-operator 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to pingcap/docs-tidb-operator. 😃

@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 14, 2024
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 17, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 19, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 19, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-17 06:39:18.874530156 +0000 UTC m=+338000.438827854: ☑️ agreed by csuzhangxc.
  • 2024-01-19 04:32:11.119578163 +0000 UTC m=+503172.683875868: ☑️ agreed by ran-huang.

@ran-huang
Copy link
Contributor

Do these changes apply to release-1.5?

@ran-huang ran-huang added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Jan 19, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jan 19, 2024
@csuzhangxc
Copy link
Member

Do these changes apply to release-1.5?

YES

@ran-huang ran-huang added the needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. label Jan 22, 2024
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 22, 2024
@ti-chi-bot ti-chi-bot bot merged commit cb89b91 into pingcap:master Jan 22, 2024
12 of 13 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.5: #2499.

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 22, 2024
Merged
6 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jan 22, 2024
@ti-chi-bot
install the ebs-csi-driver addon when creating aws eks cluster (#2484) (
f3c2432 
#2499)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ran-huang ran-huang ran-huang approved these changes

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
approved contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-1.5 Should cherry pick this PR to release-1.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xjiaqing @CLAassistant @ran-huang @csuzhangxc @ti-chi-bot