Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

en, zh: add TiProxy label description #2581

Merged
merged 5 commits into from
Jun 27, 2024
Merged

en, zh: add TiProxy label description #2581

merged 5 commits into from
Jun 27, 2024

Conversation

djshow832
Copy link
Contributor

First-time contributors' checklist

What is changed, added, or deleted? (Required)

TiDB operator v1.6.0 supports assigning node labels to TiProxy labels.

Which TiDB Operator version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v1.6 (TiDB Operator 1.6 versions)
  • v1.5 (TiDB Operator 1.5 versions)
  • v1.4 (TiDB Operator 1.4 versions)
  • v1.3 (TiDB Operator 1.3 versions)
  • v1.2 (TiDB Operator 1.2 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

@ti-chi-bot ti-chi-bot bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 3, 2024
@Oreoxmt Oreoxmt self-assigned this Jun 3, 2024
@Oreoxmt Oreoxmt added needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. labels Jun 3, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 3, 2024
@Oreoxmt Oreoxmt self-requested a review June 3, 2024 02:48
@Oreoxmt Oreoxmt added the tidb/v8.2 This PR/issue applies to TiDB v8.2. label Jun 3, 2024
Oreoxmt
Oreoxmt reviewed Jun 3, 2024
View reviewed changes
zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
en/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
en/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 3, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 5, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-03 09:27:54.944685256 +0000 UTC m=+3287028.701820821: ☑️ agreed by Oreoxmt.
  • 2024-06-05 03:06:05.269024621 +0000 UTC m=+3436919.026160190: ☑️ agreed by csuzhangxc.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 5, 2024

/cc @qiancai

@ti-chi-bot ti-chi-bot bot requested a review from qiancai June 5, 2024 06:11
qiancai
qiancai approved these changes Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

zh/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
en/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
en/configure-a-tidb-cluster.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 27, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 0b30b7b into pingcap:master Jun 27, 2024
13 of 14 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-1.6: #2585.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 27, 2024
Merged
7 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 27, 2024
@ti-chi-bot
en, zh: add TiProxy label description (#2581) (#2585)
0a1c913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csuzhangxc csuzhangxc csuzhangxc approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. lgtm needs-cherry-pick-release-1.6 Should cherry pick this PR to release-1.6 branch. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tidb/v8.2 This PR/issue applies to TiDB v8.2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@djshow832 @Oreoxmt @ti-chi-bot @csuzhangxc @qiancai