fix: remove duplicated v in version showing in the banner (#1634)

pingcap · Dec 29, 2023 · 473bf80 · 473bf80
1 parent c736225
commit 473bf80
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx b/ui/packages/tidb-dashboard-for-clinic-cloud/src/dashboardApp/layout/main/Sider/Banner.tsx
@@ -35,7 +35,11 @@ function parseVersion(i: InfoInfoResponse, t: TFunction) {
     }
     if (i.version.internal_version) {
       // e.g. v2020.07.01.1
-      return `v${i.version.internal_version}`
+      if (i.version.internal_version.startsWith('v')) {
+        return i.version.internal_version
+      } else {
+        return `v${i.version.internal_version}`
+      }
     }
     return null
   }

diff --git a/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx b/ui/packages/tidb-dashboard-for-op/src/dashboardApp/layout/main/Sider/Banner.tsx
@@ -35,7 +35,11 @@ function parseVersion(i: InfoInfoResponse, t: TFunction) {
     }
     if (i.version.internal_version) {
       // e.g. v2020.07.01.1
-      return `v${i.version.internal_version}`
+      if (i.version.internal_version.startsWith('v')) {
+        return i.version.internal_version
+      } else {
+        return `v${i.version.internal_version}`
+      }
     }
     return null
   }