profiling: use debug=1 for goroutine profile to avoid STW (#1614)

* use debug=2 for goroutines * add comment --------- Co-authored-by: Yexiang Zhang <[email protected]> Co-authored-by: Sparkle <[email protected]>
pingcap · Dec 14, 2023 · f13291e · f13291e
1 parent 5aec71c
commit f13291e
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/pkg/apiserver/profiling/pprof.go b/pkg/apiserver/profiling/pprof.go
@@ -54,7 +54,8 @@ func (f *fetcher) FetchAndWriteToFile(duration uint, fileNameWithoutExt string,
 			fileExtenstion = "*.proto"
 		}
 	case ProfilingTypeGoroutine:
-		url = "/debug/pprof/goroutine?debug=2"
+		// debug=2 causes STW when collecting the stacks. See https://github.com/pingcap/tidb/issues/48695.
+		url = "/debug/pprof/goroutine?debug=1"
 		profilingRawDataType = RawDataTypeText
 		fileExtenstion = "*.txt"
 	case ProfilingTypeMutex: