Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slow-query): show org and cluster info in clinic #1621

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Dec 5, 2023

No description provided.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai December 5, 2023 06:02
Copy link

netlify bot commented Dec 5, 2023

Deploy Preview for tidb-dashboard ready!

Name Link
🔨 Latest commit 3c8cb91
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/656ebd0b53aab20008a5a89a
😎 Deploy Preview https://deploy-preview-1621--tidb-dashboard.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ti-chi-bot ti-chi-bot bot added the size/M label Dec 5, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please ask for approval from baurine. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

Merging #1621 (3c8cb91) into master (b14203d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1621      +/-   ##
==========================================
- Coverage   24.60%   24.59%   -0.01%     
==========================================
  Files         169      169              
  Lines       15299    15299              
==========================================
- Hits         3764     3763       -1     
- Misses      11252    11253       +1     
  Partials      283      283              
Flag Coverage Δ
backend_integration 9.23% <ø> (ø)
backend_ut 26.41% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b14203d...3c8cb91. Read the comment docs.

@baurine baurine merged commit 706489f into master Dec 5, 2023
12 of 13 checks passed
@baurine baurine deleted the feat/show-org-cluster-for-slow-query branch December 5, 2023 06:12
@mornyx mornyx mentioned this pull request Dec 18, 2023
mornyx added a commit that referenced this pull request Dec 18, 2023
* feat(slow-query): show org and cluster info in clinic (#1621)

* profiling: Pass the TLS certificate to jeprof (#1624)

* support tls for tikv heap profile

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* move log

Signed-off-by: Connor1996 <[email protected]>

* use quote

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* change

Signed-off-by: Connor1996 <[email protected]>

* clean

Signed-off-by: Connor1996 <[email protected]>

* fix lint

Signed-off-by: Connor1996 <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>

* profiling: use debug=1 for goroutine profile to avoid STW (#1614)

* use debug=2 for goroutines

* add comment

---------

Co-authored-by: Yexiang Zhang <[email protected]>
Co-authored-by: Sparkle <[email protected]>

* add ticdc topology in apiserver (#1622)

* support ticdc in apiserver

* address comment

* fix lint

---------

Co-authored-by: Yexiang Zhang <[email protected]>

* update release-version

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: mornyx <[email protected]>
Co-authored-by: Sparkle <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: djshow832 <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants