Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ticdc topology in apiserver #1622

Merged
merged 4 commits into from
Dec 18, 2023

Conversation

CharlesCheung96
Copy link
Contributor

@CharlesCheung96 CharlesCheung96 commented Dec 6, 2023

Manual test:
image

Copy link

netlify bot commented Dec 6, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit ce0561b
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/657fea3ff84f7d0008eded52

@ti-chi-bot ti-chi-bot bot requested a review from Renkai December 6, 2023 12:51
@CLAassistant
Copy link

CLAassistant commented Dec 6, 2023

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #1622 (ce0561b) into master (5aec71c) will decrease coverage by 0.18%.
Report is 1 commits behind head on master.
The diff coverage is 0.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1622      +/-   ##
==========================================
- Coverage   24.59%   24.41%   -0.18%     
==========================================
  Files         169      170       +1     
  Lines       15314    15430     +116     
==========================================
+ Hits         3766     3767       +1     
- Misses      11265    11380     +115     
  Partials      283      283              
Flag Coverage Δ
backend_integration 9.20% <0.94%> (-0.03%) ⬇️
backend_ut 26.37% <0.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f13291e...ce0561b. Read the comment docs.

@CharlesCheung96 CharlesCheung96 marked this pull request as ready for review December 12, 2023 01:06
pkg/utils/topology/tidb.go Outdated Show resolved Hide resolved
@baurine
Copy link
Collaborator

baurine commented Dec 13, 2023

Please help fix the CI error as well.

Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please assign crazycs520 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baurine baurine added this pull request to the merge queue Dec 15, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 15, 2023
@mornyx mornyx merged commit 1f39ee0 into pingcap:master Dec 18, 2023
11 of 13 checks passed
mornyx added a commit that referenced this pull request Dec 18, 2023
* support ticdc in apiserver

* address comment

* fix lint

---------

Co-authored-by: Yexiang Zhang <[email protected]>
@mornyx mornyx mentioned this pull request Dec 18, 2023
mornyx added a commit that referenced this pull request Dec 18, 2023
* feat(slow-query): show org and cluster info in clinic (#1621)

* profiling: Pass the TLS certificate to jeprof (#1624)

* support tls for tikv heap profile

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* move log

Signed-off-by: Connor1996 <[email protected]>

* use quote

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* change

Signed-off-by: Connor1996 <[email protected]>

* clean

Signed-off-by: Connor1996 <[email protected]>

* fix lint

Signed-off-by: Connor1996 <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>

* profiling: use debug=1 for goroutine profile to avoid STW (#1614)

* use debug=2 for goroutines

* add comment

---------

Co-authored-by: Yexiang Zhang <[email protected]>
Co-authored-by: Sparkle <[email protected]>

* add ticdc topology in apiserver (#1622)

* support ticdc in apiserver

* address comment

* fix lint

---------

Co-authored-by: Yexiang Zhang <[email protected]>

* update release-version

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: mornyx <[email protected]>
Co-authored-by: Sparkle <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: djshow832 <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants