-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ticdc topology in apiserver #1622
Conversation
✅ Deploy Preview for tidb-dashboard canceled.
|
9d5c150
to
d6c1ee9
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1622 +/- ##
==========================================
- Coverage 24.59% 24.41% -0.18%
==========================================
Files 169 170 +1
Lines 15314 15430 +116
==========================================
+ Hits 3766 3767 +1
- Misses 11265 11380 +115
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
d6c1ee9
to
84567f3
Compare
Please help fix the CI error as well. |
429c514
to
e3f6881
Compare
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mornyx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* support ticdc in apiserver * address comment * fix lint --------- Co-authored-by: Yexiang Zhang <[email protected]>
* feat(slow-query): show org and cluster info in clinic (#1621) * profiling: Pass the TLS certificate to jeprof (#1624) * support tls for tikv heap profile Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * move log Signed-off-by: Connor1996 <[email protected]> * use quote Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * change Signed-off-by: Connor1996 <[email protected]> * clean Signed-off-by: Connor1996 <[email protected]> * fix lint Signed-off-by: Connor1996 <[email protected]> --------- Signed-off-by: Connor1996 <[email protected]> * profiling: use debug=1 for goroutine profile to avoid STW (#1614) * use debug=2 for goroutines * add comment --------- Co-authored-by: Yexiang Zhang <[email protected]> Co-authored-by: Sparkle <[email protected]> * add ticdc topology in apiserver (#1622) * support ticdc in apiserver * address comment * fix lint --------- Co-authored-by: Yexiang Zhang <[email protected]> * update release-version Signed-off-by: mornyx <[email protected]> --------- Signed-off-by: Connor1996 <[email protected]> Signed-off-by: mornyx <[email protected]> Co-authored-by: Sparkle <[email protected]> Co-authored-by: Connor <[email protected]> Co-authored-by: djshow832 <[email protected]> Co-authored-by: CharlesCheung <[email protected]>
Manual test: