Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profiling: Pass the TLS certificate to jeprof #1624

Merged
merged 8 commits into from
Dec 13, 2023
Merged

Conversation

Connor1996
Copy link
Member

@Connor1996 Connor1996 commented Dec 12, 2023

Fix #1613

Fix it by passing the TLS certificate to jeprof.

By the way, fix some potential issues in jeprof:

  • Join the port to jeprof temporarily file name, otherwise multiple instances deployed in the same host may write to same temp file
  • Clean up collected profile files when finished instead of keeping them

Manual Test:
8e6e2b17-272f-44e0-a64f-9a52f3c3de28

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
@ti-chi-bot ti-chi-bot bot requested a review from Renkai December 12, 2023 11:10
Copy link

netlify bot commented Dec 12, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit 9be9079
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/6578417e99e45a0008456387

@ti-chi-bot ti-chi-bot bot added the size/L label Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #1624 (9be9079) into master (706489f) will decrease coverage by 0.01%.
The diff coverage is 6.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1624      +/-   ##
==========================================
- Coverage   24.59%   24.59%   -0.01%     
==========================================
  Files         169      169              
  Lines       15299    15314      +15     
==========================================
+ Hits         3763     3766       +3     
- Misses      11253    11265      +12     
  Partials      283      283              
Flag Coverage Δ
backend_integration 9.23% <6.25%> (-0.01%) ⬇️
backend_ut 26.43% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 706489f...9be9079. Read the comment docs.

Signed-off-by: Connor1996 <[email protected]>
@Connor1996
Copy link
Member Author

PTAL @mornyx

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mornyx mornyx added this pull request to the merge queue Dec 13, 2023
@mornyx
Copy link
Collaborator

mornyx commented Dec 13, 2023

Thanks @Connor1996. Does ngm require the same modification? https://github.com/pingcap/ng-monitoring/tree/main/component/conprof/jeprof

@mornyx mornyx removed this pull request from the merge queue due to a manual request Dec 13, 2023
@mornyx
Copy link
Collaborator

mornyx commented Dec 13, 2023

/lgtm

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 13, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mornyx
Once this PR has been reviewed and has the lgtm label, please assign iosmanthus for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mornyx mornyx merged commit 5aec71c into pingcap:master Dec 13, 2023
11 of 13 checks passed
@Connor1996
Copy link
Member Author

Thanks @Connor1996. Does ngm require the same modification? https://github.com/pingcap/ng-monitoring/tree/main/component/conprof/jeprof

Yes

mornyx pushed a commit that referenced this pull request Dec 18, 2023
* support tls for tikv heap profile

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* move log

Signed-off-by: Connor1996 <[email protected]>

* use quote

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* change

Signed-off-by: Connor1996 <[email protected]>

* clean

Signed-off-by: Connor1996 <[email protected]>

* fix lint

Signed-off-by: Connor1996 <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>
@mornyx mornyx mentioned this pull request Dec 18, 2023
mornyx added a commit that referenced this pull request Dec 18, 2023
* feat(slow-query): show org and cluster info in clinic (#1621)

* profiling: Pass the TLS certificate to jeprof (#1624)

* support tls for tikv heap profile

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* move log

Signed-off-by: Connor1996 <[email protected]>

* use quote

Signed-off-by: Connor1996 <[email protected]>

* add log

Signed-off-by: Connor1996 <[email protected]>

* change

Signed-off-by: Connor1996 <[email protected]>

* clean

Signed-off-by: Connor1996 <[email protected]>

* fix lint

Signed-off-by: Connor1996 <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>

* profiling: use debug=1 for goroutine profile to avoid STW (#1614)

* use debug=2 for goroutines

* add comment

---------

Co-authored-by: Yexiang Zhang <[email protected]>
Co-authored-by: Sparkle <[email protected]>

* add ticdc topology in apiserver (#1622)

* support ticdc in apiserver

* address comment

* fix lint

---------

Co-authored-by: Yexiang Zhang <[email protected]>

* update release-version

Signed-off-by: mornyx <[email protected]>

---------

Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: mornyx <[email protected]>
Co-authored-by: Sparkle <[email protected]>
Co-authored-by: Connor <[email protected]>
Co-authored-by: djshow832 <[email protected]>
Co-authored-by: CharlesCheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fips: tikv heap profiling failed after enable tls and set require_secure_transport = on
2 participants