-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiling: Pass the TLS certificate to jeprof #1624
Conversation
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
Signed-off-by: Connor1996 <[email protected]>
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1624 +/- ##
==========================================
- Coverage 24.59% 24.59% -0.01%
==========================================
Files 169 169
Lines 15299 15314 +15
==========================================
+ Hits 3763 3766 +3
- Misses 11253 11265 +12
Partials 283 283
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Connor1996 <[email protected]>
PTAL @mornyx |
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks @Connor1996. Does ngm require the same modification? https://github.com/pingcap/ng-monitoring/tree/main/component/conprof/jeprof |
/lgtm |
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mornyx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Yes |
* support tls for tikv heap profile Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * move log Signed-off-by: Connor1996 <[email protected]> * use quote Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * change Signed-off-by: Connor1996 <[email protected]> * clean Signed-off-by: Connor1996 <[email protected]> * fix lint Signed-off-by: Connor1996 <[email protected]> --------- Signed-off-by: Connor1996 <[email protected]>
* feat(slow-query): show org and cluster info in clinic (#1621) * profiling: Pass the TLS certificate to jeprof (#1624) * support tls for tikv heap profile Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * move log Signed-off-by: Connor1996 <[email protected]> * use quote Signed-off-by: Connor1996 <[email protected]> * add log Signed-off-by: Connor1996 <[email protected]> * change Signed-off-by: Connor1996 <[email protected]> * clean Signed-off-by: Connor1996 <[email protected]> * fix lint Signed-off-by: Connor1996 <[email protected]> --------- Signed-off-by: Connor1996 <[email protected]> * profiling: use debug=1 for goroutine profile to avoid STW (#1614) * use debug=2 for goroutines * add comment --------- Co-authored-by: Yexiang Zhang <[email protected]> Co-authored-by: Sparkle <[email protected]> * add ticdc topology in apiserver (#1622) * support ticdc in apiserver * address comment * fix lint --------- Co-authored-by: Yexiang Zhang <[email protected]> * update release-version Signed-off-by: mornyx <[email protected]> --------- Signed-off-by: Connor1996 <[email protected]> Signed-off-by: mornyx <[email protected]> Co-authored-by: Sparkle <[email protected]> Co-authored-by: Connor <[email protected]> Co-authored-by: djshow832 <[email protected]> Co-authored-by: CharlesCheung <[email protected]>
Fix #1613
Fix it by passing the TLS certificate to jeprof.
By the way, fix some potential issues in jeprof:
Manual Test: