Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slow-query): fix cannot show RU in slow query detail page #1695

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

nolouch
Copy link
Member

@nolouch nolouch commented Jun 21, 2024

fix #1693

Test:

image

@ti-chi-bot ti-chi-bot bot requested a review from Renkai June 21, 2024 09:10
@ti-chi-bot ti-chi-bot bot added the size/M label Jun 21, 2024
@nolouch nolouch force-pushed the fix-ru-in-slowquery branch from 094be50 to 595dddd Compare June 21, 2024 09:13
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 21, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: baurine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 21, 2024
@nolouch nolouch force-pushed the fix-ru-in-slowquery branch from 2ea9d4b to c1d85e0 Compare June 24, 2024 05:22
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 24, 2024
Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-21 09:29:07.452721883 +0000 UTC m=+366273.938210715: ☑️ agreed by baurine.
  • 2024-06-24 05:22:07.378438545 +0000 UTC m=+610653.863927367: ✖️🔁 reset by nolouch.

Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

New changes are detected. LGTM label has been removed.

@nolouch
Copy link
Member Author

nolouch commented Jun 24, 2024

why is the cla always not reported?

Copy link
Contributor

ti-chi-bot bot commented Jun 24, 2024

@nolouch: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@baurine baurine merged commit 223739f into pingcap:master Jun 25, 2024
6 of 7 checks passed
@nolouch nolouch deleted the fix-ru-in-slowquery branch June 25, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SlowQueryDetail cannot show the RU information
2 participants