Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync-diff-inspector: add hint for check SQL #837

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

joechenrh
Copy link

@joechenrh joechenrh commented Jan 2, 2025

What problem does this PR solve?

Issue Number: close #836

What is changed and how it works?

Add hint /*+ USE_INDEX(...) to force index scan for checksum SQL. Note this index hint is only applied on TiDB source.

The reason we store index columns is to avoid different index names between upstream and downstream databases, even though they have same index columns.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

Copy link

ti-chi-bot bot commented Jan 2, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@CLAassistant
Copy link

CLAassistant commented Jan 2, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

ti-chi-bot bot commented Jan 2, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign 3pointer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/L label Jan 2, 2025
@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Jan 6, 2025
@ti-chi-bot ti-chi-bot bot added size/L and removed size/XL labels Jan 6, 2025
@joechenrh
Copy link
Author

/retest

1 similar comment
@joechenrh
Copy link
Author

/retest

@ti-chi-bot ti-chi-bot bot added size/XL and removed size/L labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync_diff_inspector:Add hint use_index when verifying SQL using primary key/unique key paging
2 participants