Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some audit log behaviors #59118

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

lcwangchao
Copy link
Collaborator

@lcwangchao lcwangchao commented Jan 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

This PR only used for testing

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@lcwangchao lcwangchao added the skip-issue-check Indicates that a PR no need to check linked issue. label Jan 22, 2025
Copy link

ti-chi-bot bot commented Jan 22, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lcwangchao, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 22, 2025
@lcwangchao lcwangchao marked this pull request as draft January 22, 2025 06:01
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2025
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.2067%. Comparing base (cf4d252) to head (0874c02).

Current head 0874c02 differs from pull request most recent head 4d27156

Please upload reports for the commit 4d27156 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59118        +/-   ##
================================================
+ Coverage   73.0886%   73.2067%   +0.1181%     
================================================
  Files          1686       1686                
  Lines        466442     471653      +5211     
================================================
+ Hits         340916     345282      +4366     
- Misses       104572     105269       +697     
- Partials      20954      21102       +148     
Flag Coverage Δ
integration 42.9513% <ø> (?)
unit 72.1917% <ø> (-0.0928%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 44.4962% <ø> (-0.8156%) ⬇️

@lcwangchao lcwangchao force-pushed the audit_log_fix branch 14 times, most recently from 99b23e4 to 3fb5f5a Compare January 23, 2025 08:12
Copy link

ti-chi-bot bot commented Jan 23, 2025

[FORMAT CHECKER NOTIFICATION]

Notice: To remove the do-not-merge/invalid-title label, please follow title format, for example pkg [, pkg2, pkg3]: what is changed or *: what is changed.

📖 For more info, you can check the "Contribute Code" section in the development guide.


Notice: To remove the do-not-merge/needs-tests-checked label, please finished the tests then check the finished items in description.

For example:

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

📖 For more info, you can check the "Contribute Code" section in the development guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/invalid-title do-not-merge/needs-tests-checked do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant