table: Don't cast date default values (same as timestamp/datetime) | tidb-test=920d9bf1b1137cda1272bdd59ae527aee8067944 #59149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-chi-bot
bot
added
release-note
|
I guess you might need a tidb-test change for this as well? |
YangKeao
changed the title
|
/retest |
YangKeao
changed the title
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-6.5-20241112-v6.5.11 #59149 +/- ##
=================================================================
Coverage ? 73.6096%
=================================================================
Files ? 1097
Lines ? 352928
Branches ? 0
=================================================================
Hits ? 259789
Misses ? 76410
Partials ? 16729 |
|
@dveeden Done. PTAL |
dveeden
approved these changes
Jan 23, 2025
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
tiancaiamao
approved these changes
Jan 23, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dveeden, tiancaiamao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
ti-chi-bot
bot
merged commit 7683911
into
pingcap:release-6.5-20241112-v6.5.11
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cherry-pick for #59049 on hotfix branch
What problem does this PR solve?
Issue Number: close #59047
Problem Summary:
During the executor build phase getColDefaultValue is called for the date column and fails, due to trying to cast the default value '0000-00-00' which fails due to default sql_mode.
The underlying issue seems to be that CREATE TABLE does not set column.OriginDefaultValue, while ALTER TABLE ADD COLUMN does, which is ignored in this PR.
What changed and how does it work?
Do as DATETIME and TIMESTAMP, skip cast.
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.