ddl notifier: use pessimistic txn and fix updating memory state too early #59157
Conversation
Signed-off-by: lance6716 <[email protected]>
ti-chi-bot
bot
added
release-note-none
|
Hi @lance6716. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
lance6716
changed the title
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Signed-off-by: lance6716 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #59157 +/- ##
================================================
+ Coverage 73.0571% 74.8058% +1.7487%
================================================
Files 1684 1734 +50
Lines 466439 487562 +21123
================================================
+ Hits 340767 364725 +23958
+ Misses 104729 100002 -4727
- Partials 20943 22835 +1892
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: lance6716 <[email protected]>
|
|
||
| if err = session.Begin(ctx); err != nil { | ||
| if err = session.BeginPessimistic(ctx); err != nil { |
There was a problem hiding this comment.
what's the target issue of using pessimistic txn ?
There was a problem hiding this comment.
in pessimistic txn, errors can be found earlier, such as when execute the SQL. So handler can see the error and process it. Otherwise the error is reported when COMMIT, and in current handler interface it can't be proccessed
There was a problem hiding this comment.
in pessimistic txn, errors can be found earlier
for update, if there is no check about affected rows, there is no error actually in pessimistic txn
There was a problem hiding this comment.
The original problem is handler uses the txn to insert some duplicate rows. In optimistic txn, there's no error after execute the INSERT. Using pessimistic txn handler can see "duplicate entry" error. #58980 is related
There was a problem hiding this comment.
I also checked the affected rows in bef13bf . It's revealed by old UT after switching to pessimistic txn.
ti-chi-bot
bot
added
approved
needs-1-more-lgtm
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: lance6716 <[email protected]>
There was a problem hiding this comment.
I will help test this patch along with my changes in our test infrastructure.
So let’s hold off on this PR until I finish the testing.
/hold
ti-chi-bot
bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: D3Hunter, Rustin170506 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
[LGTM Timeline notifier]Timeline:
|
|
/retest |
|
@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This comment was marked as outdated.
This comment was marked as outdated.
|
/retest |
|
@lance6716: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What problem does this PR solve?
Issue Number: close #59055
Problem Summary:
What changed and how does it work?
in pessimistic txn, errors can be found earlier, such as when execute the SQL. So handler can see the error and process it. Otherwise the error is reported when COMMIT, and in current handler interface it can't be proccessed
Check List
Tests
Side effects
Documentation
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.