Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: reuse backend for DXF subtasks of same step #59165

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

D3Hunter
Copy link
Contributor

What problem does this PR solve?

Issue Number: ref #57229, ref #57497

Problem Summary:

What changed and how does it work?

  • the local backend can be created once and shared by many subtasks at the same time,
  • solve some data race issues

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
Copy link

tiprow bot commented Jan 24, 2025

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 33.03571% with 75 lines in your changes missing coverage. Please review.

Project coverage is 74.8050%. Comparing base (cf4d252) to head (12935e8).
Report is 12 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #59165        +/-   ##
================================================
+ Coverage   73.0909%   74.8050%   +1.7140%     
================================================
  Files          1686       1735        +49     
  Lines        466442     476782     +10340     
================================================
+ Hits         340927     356657     +15730     
+ Misses       104561      97659      -6902     
- Partials      20954      22466      +1512     
Flag Coverage Δ
integration 48.7408% <8.0357%> (?)
unit 72.2523% <33.0357%> (-0.0322%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.6910% <ø> (ø)
parser ∅ <ø> (∅)
br 60.3823% <ø> (+15.0706%) ⬆️

Comment on lines -138 to -141
// TestGetTSFailDirtyState depends on the dirty state to work, i.e. some
// special branch on uni-store, else it causes DATA RACE, so we need to switch
// back to make sure it works, see https://github.com/pingcap/tidb/issues/57221
config.GetGlobalConfig().Store = storeBak
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in #57249

@D3Hunter
Copy link
Contributor Author

/retest

Copy link

tiprow bot commented Jan 24, 2025

@D3Hunter: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 24, 2025
@D3Hunter D3Hunter changed the title [wip]ddl: reuse backend for DXF subtasks of same step ddl: reuse backend for DXF subtasks of same step Jan 24, 2025
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 24, 2025
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

pkg/ddl/index.go Outdated Show resolved Hide resolved
pkg/ddl/ingest/backend_mgr.go Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jan 24, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 24, 2025
Copy link

ti-chi-bot bot commented Jan 24, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-24 07:00:31.857161931 +0000 UTC m=+423359.188081335: ☑️ agreed by tangenta.
  • 2025-01-24 07:37:23.705167259 +0000 UTC m=+425571.036086663: ☑️ agreed by lance6716.

@ti-chi-bot ti-chi-bot bot merged commit c7ce790 into pingcap:master Jan 24, 2025
25 checks passed
@D3Hunter D3Hunter deleted the add-index-reuse-backend branch January 24, 2025 13:00
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Jan 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants