-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade go-sql-driver/mysql version to v1.7.1 #2246
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2246 +/- ##
==========================================
- Coverage 55.39% 50.30% -5.08%
==========================================
Files 325 324 -1
Lines 34705 34694 -11
==========================================
- Hits 19222 17452 -1770
- Misses 13184 14955 +1771
+ Partials 2299 2287 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
unit-test reports: "Files go.sum and /tmp/go.sum.before differ". Maybe you need to run a |
tks~ |
/test unit-test |
@dveeden: No presubmit jobs available for pingcap/tiup@master In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
@dveeden: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Not sure why |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
close #2237
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: