-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix tiproxy metrics addr #2299
Conversation
Signed-off-by: xhe <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2299 +/- ##
==========================================
- Coverage 55.47% 55.43% -0.04%
==========================================
Files 326 326
Lines 34479 34478 -1
==========================================
- Hits 19125 19111 -14
- Misses 13063 13075 +12
- Partials 2291 2292 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: xhe <[email protected]>
Signed-off-by: xhe <[email protected]>
[LGTM Timeline notifier]Timeline:
|
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang, xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Playground promtheus pulls wrong metric addresses for tiproxy.
Check List
Tests
Code changes
Side effects
Related changes
Release notes: