Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the start script for alertmanager when enabling numa #2337

Merged
merged 1 commit into from
Dec 27, 2023

Conversation

KanShiori
Copy link
Collaborator

@KanShiori KanShiori commented Dec 20, 2023

What problem does this PR solve?

Close #2329

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Deploy a cluster with a alertmanager.

alertmanager_servers:
  - host: 127.0.0.1
    numa_node: "0"

Check the start script of this alertmanager.

#!/bin/bash
set -e

DEPLOY_DIR=/tidb-deploy/alertmanager-9093
cd "${DEPLOY_DIR}" || exit 1

# WARNING: This file was auto-generated. Do not edit!
#          All your edit might be overwritten!

exec > >(tee -i -a "/tidb-deploy/alertmanager-9093/log/alertmanager.log")
exec 2>&1
exec numactl --cpunodebind=0 --membind=0 bin/alertmanager/alertmanager \
    --config.file="conf/alertmanager.yml" \
    --storage.path="/tidb-data/alertmanager-9093" \
    --data.retention=120h \
    --log.level="info" \
    --web.listen-address="0.0.0.0:9093" \
    --web.external-url="http://127.0.0.1:9093" \
    --cluster.peer="127.0.0.1:9094" \
    --cluster.listen-address="127.0.0.1:9094"
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested a review from breezewish December 20, 2023 06:11
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a96dad) 55.51% compared to head (a519d44) 55.37%.

❗ Current head a519d44 differs from pull request most recent head e76f364. Consider uploading reports for the commit e76f364 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2337      +/-   ##
==========================================
- Coverage   55.51%   55.37%   -0.14%     
==========================================
  Files         328      328              
  Lines       34823    34823              
==========================================
- Hits        19330    19282      -48     
- Misses      13180    13231      +51     
+ Partials     2313     2310       -3     
Flag Coverage Δ
cluster 44.71% <ø> (-0.16%) ⬇️
dm 25.44% <ø> (-0.05%) ⬇️
playground 15.31% <ø> (ø)
tiup 33.56% <ø> (ø)
unittest 22.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 20, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 08:47:17.954031292 +0000 UTC m=+1037128.991258219: ☑️ agreed by breezewish.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Dec 27, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 27, 2023
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Dec 27, 2023
@ti-chi-bot ti-chi-bot bot merged commit e1b4850 into pingcap:master Dec 27, 2023
18 checks passed
@KanShiori KanShiori deleted the shiori/fix-alertmanager-numa branch December 27, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

numactl: execution of `bin/alertmanager': Permission denied
4 participants