Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Allow configuring pd.binpath for all PD microservices #2347

Merged
merged 2 commits into from
Jan 5, 2024

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Jan 2, 2024

What problem does this PR solve?

Currently, in PD microservice mode, users must specify binPath for each microservice, e.g.:

--pd.api.binpath=xxx
--pd.tso.binpath=xxx
...

After this PR, user can use one binPath for all microservices:

--pd.binpath=xxx    # Effective to all microservices

Users are also allowed to override binPath for particular microservice:

--pd.binpath=xxx    # Effective to all microservices except for TSO
--pd.tso.binpath=yyy

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack January 2, 2024 08:03
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2024
@breezewish breezewish requested a review from kaaaaaaang January 2, 2024 08:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (768dea3) 55.40% compared to head (468e619) 55.40%.

❗ Current head 468e619 differs from pull request most recent head b04896e. Consider uploading reports for the commit b04896e to get more accurate results

Files Patch % Lines
components/playground/main.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2347      +/-   ##
==========================================
- Coverage   55.40%   55.40%   -0.00%     
==========================================
  Files         328      329       +1     
  Lines       34822    34836      +14     
==========================================
+ Hits        19291    19298       +7     
- Misses      13225    13230       +5     
- Partials     2306     2308       +2     
Flag Coverage Δ
playground 15.37% <0.00%> (+0.05%) ⬆️
tiup 33.56% <ø> (-0.05%) ⬇️
unittest 22.34% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

ti-chi-bot bot commented Jan 2, 2024

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Jan 5, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 5, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 5, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 5, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-05 04:13:38.601087119 +0000 UTC m=+2403109.638314045: ☑️ agreed by kaaaaaaang.
  • 2024-01-05 04:13:56.547707606 +0000 UTC m=+2403127.584934533: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

@breezewish: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 5, 2024

New changes are detected. LGTM label has been removed.

@breezewish breezewish merged commit 1210bc2 into master Jan 5, 2024
6 of 7 checks passed
@breezewish breezewish deleted the wenxuan/pd-ms branch January 5, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants