-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Allow configuring pd.binpath for all PD microservices #2347
Conversation
Signed-off-by: Wish <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2347 +/- ##
==========================================
- Coverage 55.40% 55.40% -0.00%
==========================================
Files 328 329 +1
Lines 34822 34836 +14
==========================================
+ Hits 19291 19298 +7
- Misses 13225 13230 +5
- Partials 2306 2308 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@breezewish: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
New changes are detected. LGTM label has been removed. |
What problem does this PR solve?
Currently, in PD microservice mode, users must specify binPath for each microservice, e.g.:
After this PR, user can use one binPath for all microservices:
Users are also allowed to override binPath for particular microservice:
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: