-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Empty label is not allowed in Prometheus #2349
Conversation
For DM deployment there is no blackbox instances and the label value is replaced with an empty string. New Prometheus versions has a check for that: FAILED: instance 0 in group 0: no address , ssh_stdout: Checking /tidb-deploy/prometheus-9090/conf/prometheus.yml , ssh_command: export LANG=C; PATH=$PATH:/bin:/sbin:/usr/bin:/usr/sbin /tidb-deploy/prometheus-9090/bin/prometheus/promtool check config /tidb-deploy/prometheus-9090/conf/prometheus.yml}, cause: exit status 1: check config failed
Welcome @borissavelev! It looks like this is your first PR to pingcap/tiup 🎉 |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2349 +/- ##
==========================================
- Coverage 55.42% 53.36% -2.06%
==========================================
Files 329 329
Lines 34827 34827
==========================================
- Hits 19300 18582 -718
- Misses 13217 13983 +766
+ Partials 2310 2262 -48
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/approve |
@borissavelev: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
/approve |
[LGTM Timeline notifier]Timeline:
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
For DM deployment, there are no blackbox instances, and the label value is replaced with an empty string.
New Prometheus versions have a check for that: