Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off THP added to boot #2353

Closed
wants to merge 3 commits into from
Closed

Conversation

WalterWj
Copy link
Contributor

@WalterWj WalterWj commented Jan 8, 2024

What problem does this PR solve?

Troubleshoot the problem that a large page of the server opens after the server restarts

What is changed and how it works?

Start The large page is opened:
image

tiup check apply:
image

the config:
image

You can see that THP has been turned off, and the shutdown is written into the Open startup item

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Contributor

ti-chi-bot bot commented Jan 8, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from breezewish January 8, 2024 09:25
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (30d4413) 55.41% compared to head (1bb2007) 55.38%.

❗ Current head 1bb2007 differs from pull request most recent head 68e65bd. Consider uploading reports for the commit 68e65bd to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
- Coverage   55.41%   55.38%   -0.03%     
==========================================
  Files         329      329              
  Lines       34838    34852      +14     
==========================================
- Hits        19304    19301       -3     
- Misses      13225    13238      +13     
- Partials     2309     2313       +4     
Flag Coverage Δ
cluster 44.70% <100.00%> (-0.01%) ⬇️
dm 25.43% <0.00%> (-0.06%) ⬇️
playground 15.36% <ø> (-0.02%) ⬇️
unittest 22.33% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WalterWj WalterWj closed this Jan 8, 2024
@WalterWj WalterWj reopened this Jan 8, 2024
… not have the execute permission give the execute permission
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2024
Copy link
Member

@breezewish breezewish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 9, 2024
@kaaaaaaang
Copy link
Collaborator

I think the automatic modification of /etc/rc.local has too much intrusiveness and may not be suitable for all operating systems and customer environments.

@WalterWj
Copy link
Contributor Author

WalterWj commented Jan 9, 2024

I think the automatic modification of /etc/rc.local has too much intrusiveness and may not be suitable for all operating systems and customer environments.

How about a judgment in the code? Do not modify this section if the rc.local file does not exist?

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 05:53:04.891004609 +0000 UTC m=+336174.475258281: ☑️ agreed by breezewish.
  • 2024-01-11 06:46:19.666119738 +0000 UTC m=+512169.250373426: ✖️🔁 reset by WalterWj.

Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

New changes are detected. LGTM label has been removed.

@kaaaaaaang
Copy link
Collaborator

#2360

@kaaaaaaang kaaaaaaang closed this Jan 11, 2024
@WalterWj WalterWj deleted the checkApply branch January 11, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants