-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn off THP added to boot #2353
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2353 +/- ##
==========================================
- Coverage 55.41% 55.38% -0.03%
==========================================
Files 329 329
Lines 34838 34852 +14
==========================================
- Hits 19304 19301 -3
- Misses 13225 13238 +13
- Partials 2309 2313 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
… not have the execute permission give the execute permission
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think the automatic modification of /etc/rc.local has too much intrusiveness and may not be suitable for all operating systems and customer environments. |
How about a judgment in the code? Do not modify this section if the rc.local file does not exist? |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
What problem does this PR solve?
Troubleshoot the problem that a large page of the server opens after the server restarts
What is changed and how it works?
Start The large page is opened:
![image](https://private-user-images.githubusercontent.com/26704896/294897875-7cc02e35-b4f8-47a4-bd2c-fe80dcc50389.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4Mjg3NDAsIm5iZiI6MTczODgyODQ0MCwicGF0aCI6Ii8yNjcwNDg5Ni8yOTQ4OTc4NzUtN2NjMDJlMzUtYjRmOC00N2E0LWJkMmMtZmU4MGRjYzUwMzg5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA3NTQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzZDNiMDBmYjEyNjRiMDc4N2Q2NGI0NTUzM2JlZWI3MjkyYWM2MGM3MTIwMGQzNWYwODFhN2QxZmU5OWFmZDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.G5rR0kK2z6MLCrW8ujkU1UBUyhpem0vOT7iYoANaQbY)
tiup check apply:
![image](https://private-user-images.githubusercontent.com/26704896/294899304-92649f88-b918-42e3-ad3b-4acac6b6a7a7.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4Mjg3NDAsIm5iZiI6MTczODgyODQ0MCwicGF0aCI6Ii8yNjcwNDg5Ni8yOTQ4OTkzMDQtOTI2NDlmODgtYjkxOC00MmUzLWFkM2ItNGFjYWM2YjZhN2E3LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA3NTQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWQxYWQxMDg2YTk1YTI5OTM4MWZjNGNhY2NmNWRlYjZiNGExMjAxM2QzYzQ2YjhkM2YzZjIwNTlkYzc0NjM3NjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.TmO4mBUDONU7N8qXGDQx5zTpLCfNgfcEfS0enYrTR68)
the config:
![image](https://private-user-images.githubusercontent.com/26704896/294899544-fb3fc579-077d-4406-8164-7c287dab0d9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4Mjg3NDAsIm5iZiI6MTczODgyODQ0MCwicGF0aCI6Ii8yNjcwNDg5Ni8yOTQ4OTk1NDQtZmIzZmM1NzktMDc3ZC00NDA2LTgxNjQtN2MyODdkYWIwZDlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMDYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjA2VDA3NTQwMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTUzYTZjMzJlMzBiMjQ3MDhkOWY4MzExYWQzNDA3MDkxMmExNDkwZmY3M2EyNmM4MjI2YzFhMzRiOTgxZGIyNmEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.7He7X-esfo8f-VI2ZzA-a7xI9NJJu1rKPplaWyqEGTs)
You can see that THP has been turned off, and the shutdown is written into the Open startup item
Check List
Tests
Code changes
Side effects
Related changes
Release notes: