Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdms: optimize upgrade pdms to avoid unnecessary primary transfer #2414

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented May 7, 2024

What problem does this PR solve?

What is changed and how it works?

ref tikv/pd#7995

When we have 3 pdms, pdms-0/pdms-1/pdms-2, when pdms-2 is primary

  • upgrade pdms-2 firstly maybe transfer primary to pdms-0
  • and then uprade pdms-0 will transfer primary again

upgrade pdms primary in last place can avoid  unnecessary primary transfer

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Release notes:

NONE

@ti-chi-bot ti-chi-bot bot requested review from breezewish and nexustar May 7, 2024 07:22
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2024
@kaaaaaaang kaaaaaaang added this to the v1.17.0 milestone Jun 25, 2024
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp force-pushed the optimize_pdms_upgrade branch from 07d18cd to 8705617 Compare July 25, 2024 07:44
Signed-off-by: husharp <[email protected]>
@HuSharp
Copy link
Contributor Author

HuSharp commented Sep 3, 2024

@xhebox PTAL, thx~

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 3, 2024
@xhebox
Copy link
Collaborator

xhebox commented Sep 3, 2024

/approve

Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 3, 2024
@xhebox
Copy link
Collaborator

xhebox commented Sep 3, 2024

r

@xhebox PTAL, thx~

plz merge master

@ti-chi-bot ti-chi-bot bot removed the lgtm label Sep 4, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 4, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 10:37:19.023452678 +0000 UTC m=+354363.541505603: ☑️ agreed by xhebox.
  • 2024-09-04 02:04:13.941714236 +0000 UTC m=+409978.459767162: ✖️🔁 reset by HuSharp.
  • 2024-09-04 02:10:27.686830395 +0000 UTC m=+410352.204883320: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot merged commit 0b15af9 into pingcap:master Sep 4, 2024
20 checks passed
@HuSharp HuSharp deleted the optimize_pdms_upgrade branch September 4, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants