Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uninstall: more clearly messages #2488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

makocchi-git
Copy link
Contributor

What problem does this PR solve?

Currently, tiup unintall xxx shows only directory name that was deleted.

$ tiup uninstall tiup:v1.16.0
/home/user/.tiup/components/tiup/v1.16.0
/home/user/.tiup/components/tiup
Uninstalled component `tiup:v1.16.0` successfully!

This PR implements more clearly messages.

$ tiup uninstall tiup:v1.16.0
Removing directory /home/user/.tiup/components/tiup/v1.16.0
Removing directory /home/user/.tiup/components/tiup
Uninstalled component `tiup:v1.16.0` successfully!

What is changed and how it works?

This PR changes only output messages.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

uninstall: more clearly messages

Copy link
Contributor

ti-chi-bot bot commented Jan 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bb7133 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from kaaaaaaang and srstack January 12, 2025 08:17
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.24%. Comparing base (abc1b45) to head (4231f31).
Report is 1 commits behind head on master.

Current head 4231f31 differs from pull request most recent head 1e6567f

Please upload reports for the commit 1e6567f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2488      +/-   ##
==========================================
- Coverage   47.55%   44.24%   -3.31%     
==========================================
  Files         336      335       -1     
  Lines       36398    36379      -19     
==========================================
- Hits        17308    16095    -1213     
- Misses      16981    18287    +1306     
+ Partials     2109     1997     -112     
Flag Coverage Δ
cluster 25.40% <ø> (-6.74%) ⬇️
dm 25.14% <ø> (ø)
tiup 33.81% <100.00%> (ø)
unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makocchi-git
Copy link
Contributor Author

/retest

Copy link
Contributor

ti-chi-bot bot commented Jan 14, 2025

@makocchi-git: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants