Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add email subscription component #474

Merged
merged 12 commits into from
May 22, 2024

Conversation

likidu
Copy link
Collaborator

@likidu likidu commented Mar 15, 2024

@lilin90 @Yuiham

Email subscription form component for #453

In markdown file, add <EmailSubscriptionForm /> to where we want to enable the email subscription such as the release-notes.md

@likidu likidu requested a review from Yuiham March 15, 2024 04:30
Copy link

vercel bot commented Mar 15, 2024

Someone is attempting to deploy a commit to the pingcap Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website-docs ❌ Failed (Inspect) May 22, 2024 8:04am

Copy link
Collaborator

@Yuiham Yuiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likidu PTAL these comments. Thx!

src/components/MDXComponents/EmailSubscriptionForm.tsx Outdated Show resolved Hide resolved
Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the rest LGTM.

src/components/MDXComponents/EmailSubscriptionForm.tsx Outdated Show resolved Hide resolved
src/components/MDXComponents/EmailSubscriptionForm.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@Yuiham Yuiham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@likidu PTAL again, thx!

src/components/MDXComponents/EmailSubscriptionForm.tsx Outdated Show resolved Hide resolved
@Yuiham Yuiham changed the title Add email subscription form component feat: add email subscription component May 22, 2024
@Yuiham Yuiham merged commit 62390f0 into pingcap:master May 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants