Fix clang-tidy errors

pinguin999 · Dec 15, 2024 · 63252b5 · 63252b5
1 parent 4728bf4
commit 63252b5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/dialog/speech_bubble.cpp b/src/dialog/speech_bubble.cpp
@@ -5,12 +5,12 @@
 
 SpeechBubble::SpeechBubble(std::shared_ptr<Game> game,
                            const std::string &spine_file,
-                           const jngl::Text &text,
-                           const jngl::Text &characterName,
+                           jngl::Text text,
+                           jngl::Text characterName,
                            const jngl::Rgba characterNameColor
                            )
     : SpineObject(game, spine_file, "SpeechBubble", .2f),
-      text(text),
+      text(std::move(text)),
       textColor(game->getDialogManager()->textToColor((*game->lua_state)["config"]["default_font_color"])),
       characterName(characterName),
       characterNameColor(characterNameColor)

diff --git a/src/dialog/speech_bubble.hpp b/src/dialog/speech_bubble.hpp
@@ -9,8 +9,8 @@ class SpeechBubble : public SpineObject
 {
 public:
     SpeechBubble(std::shared_ptr<Game> game, const std::string &spine_file,
-                           const jngl::Text &text,
-                           const jngl::Text &characterName,
+                           jngl::Text text,
+                           jngl::Text characterName,
                            const jngl::Rgba characterNameColor);
     void draw() const override;
     bool step(bool force = false) override;

diff --git a/src/scene_fade.cpp b/src/scene_fade.cpp
@@ -2,7 +2,7 @@
 
 SceneFade::SceneFade(std::shared_ptr<jngl::Work> game,
                      std::function<void()> loadScene)
-    : loadScene(std::move(loadScene)), game(game) {}
+    : loadScene(std::move(loadScene)), game(std::move(game)) {}
 
 void SceneFade::step() {
     if (loadScene) {