Flush sync does fsync sync (#184)

* Have flushSync do a fsyncSync Signed-off-by: Matteo Collina <[email protected]> * flushSync should do fsyncSync Signed-off-by: Matteo Collina <[email protected]> --------- Signed-off-by: Matteo Collina <[email protected]>
pinojs · Oct 9, 2023 · 7ea4cf0 · 7ea4cf0
1 parent 8e981d9
commit 7ea4cf0
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/index.js b/index.js
@@ -537,6 +537,12 @@ function flushSync () {
       sleep(BUSY_WRITE_TIMEOUT)
     }
   }
+
+  try {
+    fs.fsyncSync(this.fd)
+  } catch {
+    // Skip the error. The fd might not support fsync.
+  }
 }
 
 function flushBufferSync () {

diff --git a/test/flush-sync.test.js b/test/flush-sync.test.js
@@ -80,7 +80,7 @@ test('retry in flushSync on EAGAIN', (t) => {
 })
 
 test('throw error in flushSync on EAGAIN', (t) => {
-  t.plan(11)
+  t.plan(12)
 
   const fakeFs = Object.create(fs)
   const SonicBoom = proxyquire('../', {
@@ -114,6 +114,12 @@ test('throw error in flushSync on EAGAIN', (t) => {
     throw err
   }
 
+  fakeFs.fsyncSync = function (...args) {
+    t.pass('fake fs.fsyncSync called')
+    fakeFs.fsyncSync = fs.fsyncSync
+    return fs.fsyncSync.apply(null, args)
+  }
+
   t.ok(stream.write('hello world\n'))
   t.throws(stream.flushSync.bind(stream), err, 'EAGAIN')