Convert writingBuf to Buffer to compute the original string length #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcollina
approved these changes
Dec 27, 2023
jsumners
reviewed
Dec 27, 2023
index.js
Outdated
Comment on lines
241
to
242
| } | ||
| function releaseWritingBuf (writingBuf, len, n) { |
There was a problem hiding this comment.
Suggested change
| } | |
| function releaseWritingBuf (writingBuf, len, n) { | |
| } | |
| /** | |
| * Please add a jsdoc block here. | |
| */ | |
| function releaseWritingBuf (writingBuf, len, n) { |
index.js
Outdated
Comment on lines
244
to
251
| if (typeof writingBuf === 'string' && writingBuf.length !== n) { | ||
| // Since the fs.write callback parameter `n` means how many bytes the passed of string | ||
| // We calculate the original string length for avoiding the multi-byte character issue | ||
| n = Buffer.from(writingBuf).subarray(0, n).toString().length | ||
| } | ||
| len = Math.max(len - n, 0) | ||
| writingBuf = writingBuf.slice(n) | ||
| return { writingBuf, len } |
There was a problem hiding this comment.
Could most of this be solved by comparing theBuffer.byteLength instead of theBuffer.length?
There was a problem hiding this comment.
Thank you. Using .byteLength is more sensible to compare byteLength.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Although #139 (comment) suggested converting
this._writingBufto a buffer, I found that it might reduce performance if we convert everythis._writingBufwhich just simply writes string.Therefore, I only handle cases when multi-byte characters exist.