satellite: try to integrate with host LVM/udevd #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race condition when running lvm tools in containers with other
lvm tools running on the host. Most notably, in certain situations symlinks
to the LVs could suddently disappear.
To prevent this, we try our best to integrate with the hosts LVM/udev tools:
* Reuse /run/lock/lvm and /run/lvm from the host.
* Run the container with hostIPC, some lvm tools use sysV semaphores.
* Create per-host lvmconfig:
* If there is no lvm.conf on the host, create one where we disable all udev
interactions: most likely the rules are not installed.
* If there is a lvm.conf on the host, create one where we only disable
monitoring with dmeventd.
Signed-off-by: Moritz Wanzenböck <[email protected]>
Signed-off-by: Moritz Wanzenböck <[email protected]>
|
Surprisingly, this actually worked when I tested it on:
Both with LVM and just to make sure also with ZFS pools (as there are some udev interactions with ZFS, too) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition when running lvm tools in containers with other lvm tools running on the host. Most notably, in certain situations symlinks to the LVs could suddently disappear.
To prevent this, we try our best to integrate with the hosts LVM/udev tools: