Don't show empty context menu item when all format items are disabled

piroor · Nov 13, 2023 · dccccb3 · dccccb3
1 parent 33d6c44
commit dccccb3
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/background/context-menu.js b/background/context-menu.js
@@ -361,6 +361,7 @@ async function onShown(info, tab) {
           'context_copyTab_label';
   let updated = false;
   let useTopLevelItem = false;
+  const hasMultipleVisibleItems = [...mFormatItems.values()].filter(item => item.visible).length > 1;
   for (const item of mMenuItems) {
     if (item.hiddenForTopLevelItem)
       useTopLevelItem = true;
@@ -369,7 +370,7 @@ async function onShown(info, tab) {
     item.visible = (
       !item.hiddenForTopLevelItem &&
       configs[item.config] &&
-      mFormatItems.size > 0 &&
+      hasMultipleVisibleItems &&
       (context.shouldCopyMultipleTabs || (configs.modeForNoSelection != Constants.kCOPY_NOTHING))
     );
     item.title = browser.i18n.getMessage(titleKey);