Fix: In rest_server_test Allow "view-localhost" hostname #1282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test already allowed "localhost" and "ip6-localhost". "view-localhost" was seen on Windows 10 by @Kreijstal . We now allow any hostname ending in "localhost" to be accepted as a hostname. Addresses part of issue pistacheio#1281.
kiplingw
approved these changes
Jan 14, 2025
kiplingw
added
bug
portability
unit / CI testing
Tachi107
reviewed
Jan 15, 2025
| @@ -117,14 +117,14 @@ TEST(rest_server_test, basic_test) | |||
| ASSERT_EQ(res->status, 200); | |||
|
|
|||
| // TODO: Clean this up to use proper gtest macros. | |||
| // NOTE: res->body is "ip6-localhost" on some architectures. | |||
| if (res->body == "ip6-localhost") | |||
| if ((res->body.length() >= 9) && // 9 being len of "localhost" | |||
There was a problem hiding this comment.
instead of hardcoding 9, you could write strlen("localhost"). It's self-documenting
There was a problem hiding this comment.
Or, even better, you can use EXPECT_THAT(res->body, testing::EndsWith("localhost"))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test already allowed "localhost" and "ip6-localhost". "view-localhost" was seen on Windows 10 by @Kreijstal . The test now allows any hostname ending in "localhost" to be accepted as a hostname.
Addresses part of issue #1281.