Skip to content

Commit

Permalink
Link with arrow_compute_testing
Browse files Browse the repository at this point in the history
  • Loading branch information
pitrou committed Jan 16, 2025
1 parent bc68bfb commit b29cb69
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions cpp/src/arrow/acero/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -109,16 +109,15 @@ endforeach()
if(ARROW_TESTING)
# test_nodes.cc isn't used by all tests but link to it for simple
# CMakeLists.txt.
add_library(arrow_acero_testing OBJECT test_nodes.cc test_util_internal.cc
../compute/test_util_internal.cc)
add_library(arrow_acero_testing OBJECT test_nodes.cc test_util_internal.cc)
# Even though this is still just an object library we still need to "link" our
# dependencies so that include paths are configured correctly
target_link_libraries(arrow_acero_testing PRIVATE ${ARROW_ACERO_TEST_LINK_LIBS})
# Only for test_nodes.cc.
if(ARROW_WITH_OPENTELEMETRY)
target_link_libraries(arrow_acero_testing PRIVATE ${ARROW_OPENTELEMETRY_LIBS})
endif()
list(APPEND ARROW_ACERO_TEST_LINK_LIBS arrow_acero_testing)
list(APPEND ARROW_ACERO_TEST_LINK_LIBS arrow_acero_testing arrow_compute_testing)
endif()
# Only for hash_aggregate_test.cc.
if(ARROW_USE_BOOST)
Expand Down
4 changes: 2 additions & 2 deletions cpp/src/arrow/dataset/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -106,10 +106,10 @@ endif()

if(ARROW_TEST_LINKAGE STREQUAL "static")
set(ARROW_DATASET_TEST_LINK_LIBS arrow_dataset_static arrow_acero_testing
${ARROW_TEST_STATIC_LINK_LIBS})
arrow_compute_testing ${ARROW_TEST_STATIC_LINK_LIBS})
else()
set(ARROW_DATASET_TEST_LINK_LIBS arrow_dataset_shared arrow_acero_testing
${ARROW_TEST_SHARED_LINK_LIBS})
arrow_compute_testing ${ARROW_TEST_SHARED_LINK_LIBS})
endif()

foreach(LIB_TARGET ${ARROW_DATASET_LIBRARIES})
Expand Down

0 comments on commit b29cb69

Please sign in to comment.