Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added check for existing overrides in add-missing-override #447

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Added check for existing overrides in add-missing-override #447

merged 1 commit into from
Sep 17, 2024

Conversation

andrecsilva
Copy link
Contributor

If you have multiple findings of the same rule for the same location, some codemods will duplicate their fixes.

This PR adds a patch to stop this for the add-missing-override codemod.

@andrecsilva andrecsilva marked this pull request as ready for review September 17, 2024 10:32
@andrecsilva andrecsilva requested a review from nahsra September 17, 2024 10:33
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@andrecsilva andrecsilva merged commit 50cf515 into main Sep 17, 2024
6 checks passed
@andrecsilva andrecsilva deleted the fix-S1161 branch September 17, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nahsra nahsra nahsra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrecsilva @nahsra