New CodeQL Error Message Exposure codemod #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrecsilva
changed the title
nahsra
requested changes
Nov 21, 2024
| import java.util.Optional; | ||
| import javax.inject.Inject; | ||
|
|
||
| /** A codemod for automatically fixing SQL injection from CodeQL. */ |
nahsra
reviewed
Nov 21, 2024
| import java.util.Optional; | ||
|
|
||
| /** Removes exposure from error messages. */ | ||
| public final class ErrorMessageExposureFixStrategy extends MatchAndFixStrategy { |
There was a problem hiding this comment.
Does this need to be public? Shouldn't this be package-protected?
nahsra
approved these changes
Nov 21, 2024
andrecsilva
force-pushed
the
ISS-2415/cql-info-exposure
branch
from
2530d1d to
ccaad27
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrote StackTraceExposureCodemod with the remediator API. Also added support for a new case.
Fixed a node position matching bug. Had to adjust/fix some codemods and tests.
Fixed flakyness from a codemod.
\close #work