Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for json5 #94

Merged
merged 2 commits into from
Oct 14, 2024
Merged

feat: add support for json5 #94

merged 2 commits into from
Oct 14, 2024

Conversation

GoodBoyDigital
Copy link
Member

Adds support for the .json5 format. Basically allows for json files to have comments and few other quality of life things. See more here

This just upgrades our existing json parser to use the json5 parser instead. Which means json5 files will be transformed to json files.

You can also add comments to your json files and they will be stripped out.

example of valid json5:

myJson.json5

{
    // so cool support for comments
    hello: "world",
    Im: "not broken"
}

woud become:

myJson.json

{"hello":"world","Im":"not broken"}

tests added 👍

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR title doesn't match the required format. The title should be in this format:

chore: update docs

@GoodBoyDigital GoodBoyDigital changed the title add support for json5 feat: add support for json5 Oct 7, 2024
@Zyie Zyie merged commit 2d77554 into main Oct 14, 2024
4 checks passed
@Zyie Zyie deleted the feature/json5 branch October 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants