Add loading progress bar to the creation template #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberDex
commented
Dec 11, 2024
| @@ -5,7 +5,8 @@ | |||
| "type": "module", | |||
| "scripts": { | |||
| "build": "tsc && vite build", | |||
| "dev": "vite" | |||
| "dev": "vite", | |||
| "start": "vite" | |||
There was a problem hiding this comment.
It's nice to have this in all the templates
There was a problem hiding this comment.
yeah if you want to do a pr to add this to all the templates I'm ok with adding it in
Zyie
approved these changes
Dec 11, 2024
Zyie
added
the
✅ Ready To Merge
CyberDex
deleted the
5-add-loading-progress-bar-to-the-creation-template
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
onLoadmethod of theAppScreenmay be helpful not only for the loading screen but also for any active screen that can react when switching to the next screen or showing the popup.For example, if screen switching happens on a button click, we may want to show the loading message on the button or, instead, the button. This indicates to the user that something is happening.