Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: TiltShiftFilter coordinates are calculated incorrectly #483

Merged
merged 6 commits into from
Jan 16, 2025

Conversation

amoffat
Copy link
Contributor

@amoffat amoffat commented Dec 30, 2024

Fixes #470

@amoffat
Copy link
Contributor Author

amoffat commented Dec 30, 2024

Demo

2024-12-29.22-48-46.mp4

@bigtimebuddy
Copy link
Member

Thanks for the PR @amoffat. I'm still getting popping when resizing the filter.

Copy link
Member

@GoodBoyDigital GoodBoyDigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@GoodBoyDigital GoodBoyDigital self-requested a review January 6, 2025 15:07
@amoffat
Copy link
Contributor Author

amoffat commented Jan 6, 2025

Thanks for the PR @amoffat. I'm still getting popping when resizing the filter.

Ok will take a look

@amoffat
Copy link
Contributor Author

amoffat commented Jan 14, 2025

@bigtimebuddy Ok I've fixed the popping issue and ported the fix to wgsl, but I can't test the wgsl fix on my machine.

@bigtimebuddy
Copy link
Member

Thank you @amoffat I will verify the wgsl side

@bigtimebuddy bigtimebuddy merged commit 432c0e1 into pixijs:main Jan 16, 2025
1 check passed
@amoffat amoffat deleted the amoffat/issue470 branch January 16, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: TiltShiftFilter coordinates are calculated incorrectly
3 participants