-
-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [WIP] @pixi/react
v8
#490
Conversation
This reverts commit 9f875d4.
@pixi/react
v8@pixi/react
v8
@pixi/react
v8@pixi/react
v8
What's the reasoning behind a complete rewrite rather than bumping the signatures from the prior version? |
I'm also curious to know the rational behind a full re-write. The current version already has an implementation of a react reconciler, which seems to work with react fiber, with what looks like a well though out reconciliation strategy and event priorities. Could we perhaps get some more insight behind the factors that you considered? There is a lot of code that is being removed, and with it a lot of accumulated knowledge and "chesterton fences". |
maybe?
|
Definitely not backwards-compatible. |
hello :) thanks! |
I've closed this PR since I've moved development to the |
Description of change
This is a complete rewrite of
@pixi/react
. It leverages reflection and type inference to provide a new React pragma, allowing usage of all Pixi.js components via JSX within React applications.A nice side effect is that this new version should be backward-compatible.
This PR supersedes @Zyie's work on #483, since we're now rewriting the library from the ground up.
Fixes: #476
Pre-Merge Checklist
npm run lint
)npm run test
)