Send app state to context #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Splits application state and internal state * Adds `isInitialised` to the app state
trezy
added
bug
trezy
force-pushed
the
506-bug-usetick-not-ticking-on-initial-load-during-vite-dev
branch
from
db12ea6 to
1b1c7b9
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0987eba:
|
trezy
deleted the
506-bug-usetick-not-ticking-on-initial-load-during-vite-dev
branch
|
🎉 This issue has been resolved in version 8.0.0-beta.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
We're now tracking
isInitialisedin Pixi React's application state. We're then using this inuseTickto ensure the callback gets setup once the application is initialised. This solves #506, which was being caused by the application not being initialised the first timeuseTickruns in an SSR environment, then being initialised after a hot module reload.Fixes: #506
Pre-Merge Checklist
npm run lint)npm run test)