-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unprefixed elements #559
Conversation
BREAKING CHANGE: unprefixed elements must be explicitly added Signed-off-by: Trezy <[email protected]>
Signed-off-by: Trezy <[email protected]>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1ba1ba6:
|
Signed-off-by: Trezy <[email protected]>
0b85efa
to
2e0981d
Compare
I tested the PR in 2 passes on an existing project...
It might be worth documenting the pattern for extending built in types, as it changes slightly as well... // before @pixi/react#559
export type TilingSpriteProps = JSX.IntrinsicElements['tilingSprite'] & {
image?: string;
texture?: Texture;
};
// after @pixi/react#559
export type TilingSpriteProps = PixiElements['pixiTilingSprite'] & {
image?: string;
texture?: Texture;
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great solution, works wonderfully and leaves control in the user's hands for pixi element naming preference.
Signed-off-by: Trezy <[email protected]>
🎉 This PR is included in version 8.0.0-beta.20 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Description of change
Fixes: #549
Pre-Merge Checklist
npm run lint
)npm run test
)