fix: Remove union types from ConstructorOptions #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 814a351:
|
trezy
approved these changes
Jan 4, 2025
|
🎉 This PR is included in version 8.0.0-beta.19 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Container, Sprite and Graphics all have constructors that union the options with Texture | GraphicsContext | undefined, these types are not valid as props for a component, and the union was causing Omit and other utils to produce incorrect types when trying to extend the builtin types.
Excluding the unioned types from ConstructorOptions eleminates potential incorrect props and allows for Pick, Omit, etc to work as expected.
Fixes:
Pre-Merge Checklist
npm run lint)npm run test)