feat(Input): Added secure input functionality for typing passwords #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchABus
requested review from
Zyie,
GoodBoyDigital and
CyberDex
as code owners
CatchABus
added a commit
that referenced
this pull request
Nov 30, 2024
) * perf(Input): Use substring to remove last character * feat(Input): Added secure input functionality for typing passwords * chore: Updated input stories * chore: Secure fallback value --------- Co-authored-by: Dmytro Soldatov <[email protected]>
CatchABus
added a commit
that referenced
this pull request
Dec 1, 2024
) * perf(Input): Use substring to remove last character * feat(Input): Added secure input functionality for typing passwords * chore: Updated input stories * chore: Secure fallback value --------- Co-authored-by: Dmytro Soldatov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds secure functionality for inputs that accept passwords.
It will replace all characters with
*and secure state is toggleable itself.Input will accept
secureas an option and instance property.Now, let's say develop wants to add a show/hide password button like most forms do nowadays.
By setting property
securetofalse, Input will display the original text content. Setting it back totruewill display asterisks again.Additionally, I took the chance to improve performance on character deletion a little bit by using
substringinstead of array operations.