[feature] 로고 및 피드 업로드 기능 구현 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zepelown
requested changes
Jan 29, 2025
| @RestController | ||
| @RequestMapping("/api/club") | ||
| @RequiredArgsConstructor | ||
| public class GcsController { |
There was a problem hiding this comment.
결국 Club에 대한 도메인이라 Clubcontroller에 작성하거나, ClubImageUploadController 처럼 더 club이 기능을 강조하는 것이 어떨까요?
There was a problem hiding this comment.
전혀 생각 못한 부분인데 생각해 보니 그렇네요!
Clubcontroller 에서 다루는 클럽의 텍스트 데이터들을 다루는 것과 이미지 데이터를 다루는 부분은 성격이 조금 다른 것 같아서 ClubImageController 로 수정하였습니다~
|
|
||
| @Service | ||
| @RequiredArgsConstructor | ||
| public class GcsService { |
There was a problem hiding this comment.
이 또한 ClubImageUploadService나 ClubImageService로 도메인을 club으로 합치면 좋지 않을까요?
There was a problem hiding this comment.
넵 이부분도 위와 마찬가지로 ClubImageService로 변경하였습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
SecurityConfig에 GCS 인증 & storage 객체를 Bean에 등록하였음
컨트롤러에서 로고 업데이트인지 피드 업데이트인지에 대한 정보를 받고
기본적인 영상 업로드 전 전처리를 해 준 후
uploadFile을 호출하여 중복을 최소화 하였음
로고 이미지 업로드 확인
피드 이미지(2개) 업로드 확인