Skip to content

Commit

Permalink
#9825 Fix missing parameter in call to map(...)
Browse files Browse the repository at this point in the history
  • Loading branch information
asmecher committed May 7, 2024
1 parent 88324c2 commit de3b6b1
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions api/v1/reviews/PKPReviewController.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ public function getHandlerPath(): string

/**
* @copydoc \PKP\core\PKPBaseController::getRouteGroupMiddleware()
*
* @throws \Exception
*/
public function getRouteGroupMiddleware(): array
Expand Down Expand Up @@ -85,6 +86,7 @@ public function authorize(PKPRequest $request, array &$args, array $roleAssignme

/**
* Get reviewer's submission round history
*
* @throws \Exception
*/
public function getHistory(Request $illuminateRequest): JsonResponse
Expand Down Expand Up @@ -120,7 +122,7 @@ public function getHistory(Request $illuminateRequest): JsonResponse
$section = Repo::section()->get($submission->getSectionId());
$publicationType = $section->getData('title');
}

$publicationAbstract = $publication->getData('abstract');
$publicationKeywords = $publication->getData('keywords');

Expand All @@ -142,7 +144,7 @@ public function getHistory(Request $illuminateRequest): JsonResponse
}
}

$reviewAssignmentProps = Repo::reviewAssignment()->getSchemaMap()->map($reviewAssignment);
$reviewAssignmentProps = Repo::reviewAssignment()->getSchemaMap()->map($reviewAssignment, $submission);
// It doesn't seem we can translate the recommendation inside the vue page as it's a dynamic label key.
$recommendation = $reviewAssignment->getLocalizedRecommendation();

Expand Down Expand Up @@ -170,7 +172,7 @@ public function getHistory(Request $illuminateRequest): JsonResponse
->filterByFileStages([SubmissionFile::SUBMISSION_FILE_REVIEW_ATTACHMENT])
->filterByAssoc(PKPApplication::ASSOC_TYPE_REVIEW_ASSIGNMENT, [$reviewAssignmentId])
->getMany();

$attachmentsProps = Repo::submissionFile()
->getSchemaMap()
->mapMany($attachments, $fileGenres)
Expand Down

0 comments on commit de3b6b1

Please sign in to comment.