Request for new OP DOI RA plugin in the gallery

[njikonga-med]

Hello @asmecher or @bozana, This is request to include a new plugin to the gallery for the DOI registration agency Open Publications.
All the required information have been provided in the snippet. Please could you please verify and let me know?

With regards,
Jehu Njikonga

[bozana]

Hi @njikonga-med, I will take a look at the plugin and will then let you know...
(In the meantime: is the change of the .gitignore here by accident or wanted?)
Thanks a lot!

[njikonga-med]

Hi @njikonga-med, I will take a look at the plugin and will then let you know... (In the meantime: is the change of the .gitignore here by accident or wanted?) Thanks a lot!

Hi @bozana , the change of the .gitignore is not there accidently, it's because I opened the project with Eclipse and automatically, it creates the .project, and that is the reason. Maybe there is no need of putting it inside the .gitignore?

Thanks,
Jehu Njikonga

[njikonga-med]

Hi @bozana , hope this short message find you well. Waiting for the snippet approval of OP DOI RA new plugin in the gallery. Any news?

With regards,
Jehu Njikonga

[bozana]

HI @njikonga-med, I need to review the plugin, but I (we all) are so busy with the coming 3.5 that I will need a little bit more time for this. I will get to it as soon as possible, I hope this week. Sorry for the delay and thanks for understanding.

[njikonga-med]

Ok. thanks.

[bozana]

Hi @njikonga-med,
Sorry for the delay. I first now managed to take a look at the plugin. I would have a few comments:

• OPdoiraDoiDataMigration.php is not needed, also the function OPdoiraPlugin::preInstall() and the hook Hook::add('Installer::preInstall', [$this, 'preInstall']); in function OPdoiraPlugin::register() -- this class and function are for users that come and upgrade from OJS 3.3 to OJS 3.4, where DOIs were significantly changed and needed to be moved into different tables.
• You probably do not need the folder tests/, if you do not want to write and maintain the tests. Also in this folder medra occurs in few places:
  In OPdoiraWebserviceTest.php there is use APP\plugins\generic\medra\classes\OPdoiraWebservice;.
  In serial-article-as-work.xml and serial-issue-as-work.xml there is medra in schemaLocation, ToCompany and RegistrationAuthority.
• In OPdoiraWebservice: medra is in SOAP-ENV and in attachment and soapMessage id. Maybe this is OK so?
• In ArticleOPdoiraXmlFilter::appendCitationListNodes(): $opdoiraCitationNamespace contains medra. Maybe this is OK so?

Have you managed also to test the plugin and register the DOIs?

Thanks a lot!