TransferAssets payload size 설정 #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ipdae
commented
Apr 15, 2024
ipdae
commented
- 100으로 고정되있던 TransferAssets의 Recipients 숫자를 설정가능하게 고칩니다.
U-lis
reviewed
Apr 17, 2024
| result_format = f"world_boss_{raid_id}_{total_count}_{start_nonce}_result" | ||
| write_ranking_rewards_csv(file_name, results, raid_id, start_nonce, size) | ||
| result_format = ( | ||
| f"world_boss_{raid_id}_{total_count}_{start_nonce}_{size}_result" |
There was a problem hiding this comment.
Shouldn't we save result csv with payload_size? I think actual size delivered is payload_size and this should be saved to result CSV.
There was a problem hiding this comment.
Since there is a possibility that payload_size may change, left the size used when executing.
U-lis
reviewed
Apr 17, 2024
| @@ -152,7 +153,7 @@ def write_ranking_rewards_csv( | |||
| amount, | |||
| currency["ticker"], | |||
| currency["decimalPlaces"], | |||
| start_nonce + int(i / 100), | |||
| start_nonce + int(i / size), | |||
There was a problem hiding this comment.
int(i / size) : i // size also can do this 😃
U-lis
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.