Remove cacert.pem installation on Windows #236
+622
−332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move 'init' responsibility to the legacy package
- Remove unnecessary Debug on wrapper
- Remove --phar-path option, but preserve {ENV_PREFIX}PHAR_PATH variable
- Remove unnecessary global vars
- Add a test
- Check the files on each run - Try to avoid partial writes - Move temporary directory from /tmp to the home directory
|
It's possible someone had a broken system cert file (e.g. in |
pjcdawkins
force-pushed
the
compare-file-hashes
branch
2 times, most recently
from
f1d100d to
1d74939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #201 but rebased on (targeting) #94
Manual testing on Windows 11 Home (VM) shows it works ok.
Though I'm not sure the details of the original problem that led to the file being added.